-
Notifications
You must be signed in to change notification settings - Fork 1.9k
chore(deps): bump the proto group with 3 updates #19325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d9992c7 to
fccd0b9
Compare
adc8b2f to
7836d65
Compare
Contributor
|
@dependabot rebase |
Bumps the proto group with 3 updates: [pbjson](https://github.com/influxdata/pbjson), [pbjson-types](https://github.com/influxdata/pbjson) and [pbjson-build](https://github.com/influxdata/pbjson). Updates `pbjson` from 0.8.0 to 0.9.0 - [Commits](https://github.com/influxdata/pbjson/commits/0.9.0) Updates `pbjson-types` from 0.8.0 to 0.9.0 - [Commits](https://github.com/influxdata/pbjson/commits/0.9.0) Updates `pbjson-build` from 0.8.0 to 0.9.0 - [Commits](https://github.com/influxdata/pbjson/commits/0.9.0) --- updated-dependencies: - dependency-name: pbjson dependency-version: 0.9.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: proto - dependency-name: pbjson-types dependency-version: 0.9.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: proto - dependency-name: pbjson-build dependency-version: 0.9.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: proto ... Signed-off-by: dependabot[bot] <[email protected]>
7836d65 to
4adadce
Compare
Contributor
|
Substrait hasn't upgraded to 0.9.0 yet: We'd need version bump from substrait anyway. So downgrade the dependency to unblock this PR. |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 11, 2026
## Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123. --> - N/A ## Rationale for this change <!-- Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed. Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. --> Occasionally we do PRs to bump a bunch of versions in `Cargo.lock`, recent example: - #19667 Ideally this should be handled by dependabot already. I suspect the default limit of 5 is preventing dependabot from creating all the PRs it needs; this causes it to error and those version bumps are "lost". - I say "lost" but dependabot can pick it up on the next run... if it doesn't error again See an example from a dependabot run: <img width="703" height="118" alt="image" src="https://github.com/user-attachments/assets/f8ae6b70-6fe1-4613-8c60-28564c23188b" /> From the logs: ```text +-------------------------------------------------------+ | Changes to Dependabot Pull Requests | +---------+---------------------------------------------+ | created | insta ( from 1.45.0 to 1.46.0 ) | | created | tracing ( from 0.1.43 to 0.1.44 ) | | created | syn ( from 2.0.111 to 2.0.113 ) | | created | async-compression ( from 0.4.35 to 0.4.36 ) | | created | object_store ( from 0.12.4 to 0.13.0 ) | | created | serde_json ( from 1.0.145 to 1.0.148 ) | | created | bigdecimal ( from 0.4.9 to 0.4.10 ) | | created | clap ( from 4.5.53 to 4.5.54 ) | | created | libc ( from 0.2.177 to 0.2.179 ) | | created | tokio ( from 1.48.0 to 1.49.0 ) | | created | tokio-util ( from 0.7.17 to 0.7.18 ) | | created | sqllogictest ( from 0.28.4 to 0.29.0 ) | +---------+---------------------------------------------+ ``` We expect to have all these PRs created (this was for the run 5 days ago), but only these were created on that day: - #19645 - #19644 - #19643 And considering these PRs were still open at the time: - #19544 - #19325 We can see it hit the 5 limit. > Dependabot default behavior: > > - If five pull requests with version updates are open, no further pull requests are raised until some of those open requests are merged or closed. > - Security updates have a separate, internal limit of ten open pull requests which cannot be changed. - https://docs.github.com/en/code-security/dependabot/working-with-dependabot/dependabot-options-reference#open-pull-requests-limit- ## What changes are included in this PR? <!-- There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR. --> Bump the limit to 15. We might have an appetite for increasing it more, 15 was chosen arbitrarily. ## Are these changes tested? <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> Dependabot only. ## Are there any user-facing changes? <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> No. <!-- If there are any breaking changes to public APIs, please add the `api change` label. -->
Contributor
Author
|
Looks like these dependencies are updatable in another way, so this is no longer needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps the proto group with 3 updates: pbjson, pbjson-types and pbjson-build.
Updates
pbjsonfrom 0.8.0 to 0.9.0Commits
Updates
pbjson-typesfrom 0.8.0 to 0.9.0Commits
Updates
pbjson-buildfrom 0.8.0 to 0.9.0Commits
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>will remove the ignore condition of the specified dependency and ignore conditions